Tom Tromey <[EMAIL PROTECTED]> writes:

> Brian> What's very confusing here is libgcj's implementation has a
> Brian> classpath header but does not appear to be exactly the
> Brian> same... so I guess these aren't merged yet.  Is anyone working
> Brian> on that?
> 
> Warren has been working on serialization lately.  He told me he is
> going to check in the changes to Classpath soon.  I don't know when.
> We're definitely not going to allow divergence in code that we share.

Thanks for the info, I wanted to send a small patch concerning this
class against libgcj's implementation but for some reason anoncvs is
broken this morning (can't update or do a diff), and I already removed
the original...  Anyway, in ObjectStreamClass.lookup (Class) it should
look something like this with the check for serialization moved to
somewhere more appropriate to match the comments and Sun's own docs.

  public static ObjectStreamClass lookup (Class cl)
  {
    if (cl == null)
      return null;
    if (! (Serializable.class).isAssignableFrom (cl))
      return null;

    ObjectStreamClass osc = (ObjectStreamClass)classLookupTable.get (cl);

    if (osc != null)
      return osc;
    else
    {
      osc = new ObjectStreamClass (cl);
      classLookupTable.put (cl, osc);
      return osc;
    }
  }

I'm eagerly awaiting the merge.  :)

Brian
-- 
Brian Jones <[EMAIL PROTECTED]>

Reply via email to