When considering the line of VM classes, shouldn't the
FileChannelImpl class in gnu.java.nio not be called
VMFileChannel(Impl) in the java.nio package.
That way we all have the freedom how to implement it.



Yeah, it should be named VMFileChannel. We dont did that yet because of ... guess what ... right: laziness.


Well we all have that :-)



As an alternative (which is i my opinion better), a VMFileChannel
class should have a static member used to instantatie the
FileChannel implementation of choice.



What do you mean by this ?



Now the FileInputStream constructor does a "new FileChannelImpl(...)", instead i suggest to let is call "VMFileChannel.open(...)" that returns a FileChannel implemented by the VM. The default implementation would be to return a new FileChannelImpl, so that would mean no native changes.


Ewout





Michael





_______________________________________________ Classpath mailing list [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/classpath

Reply via email to