Sebastien Roy wrote: > Sebastien Roy wrote: >> I have a fix for: >> >> 6640357 ifconfig: cannot open link "ip6.tun(n)": Invalid argument >> >> http://zhadum.east/ws/seb/seb_uvfix/webrev/ >> >> The fix is to have dls_mgmt_get_linkid() return an error code rather than >> a link id (since it can fail for a multitude of reasons that >> DATALINK_INVALID_LINKID cannot represent), and have it pass back the >> error returned by i_dls_mgmt_upcall() instead of always returning >> DATALINK_INVALID_LINKID. dls_mgmt_get_linkid() should also explicitly >> return ENOENT in a number of cases instead of EINVAL. >> >> I've tested the fix manually using ifconfig. >> >> If folks are okay with this, I'll put it back and provide PIT with a fix. > > For those curious souls not on SWAN, the webrev is: > > http://cr.opensolaris.org/~seb/6640357/ > Seb,
I am wondering whether this bug should be just fixed if we change line 1066 of dls_mgmt.c (th old code) to return ENOENT instead of EINVAL? Of course, there are other places in this function that should return ENOENT too. Thanks - Cathy
