Cathy Zhou wrote: > I am wondering whether this bug should be just fixed if we change line > 1066 of dls_mgmt.c (th old code) to return ENOENT instead of EINVAL?
That would fix this particular failure, yes. It would leave behind other cases where EINVAL is erroneously returned, though, which is why the fix is slightly more involved. I should have expanded on that in the CR Evaluation. > Of course, there are other places in this function that should return > ENOENT too. Right, and more generally, codes other than EINVAL. For example, the change at 1076 will now return the actual failure of dls_mgmt_get_linkid() or dls_mgmt_get_phydev() if an error in one of those functions occurs. -Seb
