Peter Memishian wrote: > > As a comment from Eric, that he prefers to make the margin size of the > > DL_ETHER links to be 4, so that we don't have to change all DL_ETHER > > drivers. > > > > If so, I intent to add a mtr_dft_margin field into the > > mactype_register_t, which is used to specify the default margin size > > for this media type. > > > > What do you think? > > I'm not sure I understand the motivation. If it's actually true that most > Ethernet drivers (and not other types of drivers) have a margin of 4, then > I'm fine with such a change. But doing it just to avoid updating the > drivers doesn't make sense to me. > I tends to agree. I remembered we used to have this discussion with Garret. It seems that different people have different take on this.
I will wait for more people to comment on this and will leave the code as is for now. Thanks - Cathy > If you do decide to go ahead with a "default" field, "def" is a more > standard abbreviation than "dft". >
