On Thu, Jan 03, 2008 at 12:11:48AM +0800, Peter Memishian wrote: > > My concern is that "margin" is intended to be used for things other than > VLANs -- but both by having the margin have a per-mactype-plugin default > value, and by having that value default to 4, we're really wiring > everything up to be VLAN-specific. (e.g., the only reason why 4 makes > sense as the default for Ethernet is because we're assuming that it's > being used for VLANs, and VLANs are only supported on Ethernet.) > > I agree that driver writers will initially puzzle at the "margin" concept, > and some may struggle to find an appropriate value. But if we're going to > support such a concept (and it seems like it is also useful for RBridges), > I think we need to treat it as a first-class entity and expect driver > writers to set it correctly so that Solaris can appropriately make use of > it both now and in the future. If we instead try to guess a value, I > think we will have a tough time supporting anything other than VLANs. > > In any case, I'd hope this matter isn't a showstopper but if it is please > let us know ASAP since any changes here will have testing impact and we're > doing testing for final approach now. >
I agree this isn't a stopper and I am fine with not adding a default. eric
