> All this callback would call the corresponding do_set(get)_* functions > at last.All the do_set(get)_* functions have same prototype with a gbuf > parameter, and we do this because most the do_set(get)_functions are > used in do_connect which called by wladm_connect in which do_connect may > be called several times.So we can malloc a gbuf and pass it to > do_connect(..) in which several do_set_* functions are called and pass > the gbuf to all these functions.From this view I thinkt that it's some > better to malloc gbuf out of do_set(get)_* functions.
I don't think this matters much; do_connect() is a slow operation; the number of malloc() calls makes no real difference. -- meem
