Artem Kachitchkine wrote:
> I'm thinking about fixing:
> 
>       6688428 dladm init-linkprop ignores private properties
> 
> Current algorithm for walking public properties in dladm_walk_linkprop() is:
> 
>       for 'field' in (known public property names)
>               read 'field' from datalink.conf
> 
> But private property names are not "known". If the driver accepts 
> whatever you feed it via 'dladm set-linkprop', it is saved in 
> datalink.conf. To read all saved private properties, I could do what Dr. 
> Gregory House would do:
> 
>       for 'field' in (all fields in datalink.conf)
>               if 'field' not in (known field names)
>                       then 'field' is a private property
> 
> where (known field names) includes all public properties and reserved 
> names like "name", "class", "media", etc. Is this acceptable or can 
> someone think of a better way?
> 
although I don't see other alternatives with our current design, I don't like 
the above approach. Does that mean "nports" (of an aggregation) would be a 
private link property?

Thanks
- Cathy

> -Artem
> 
> _________________________________
> clearview-discuss mailing list
> clearview-discuss at opensolaris.org


Reply via email to