On Fri, 2008-04-25 at 17:05 -0400, Peter Memishian wrote: > > I've implemented what is IMO a cleaner fix: > > > > http://cr.opensolaris.org/~seb/physaddr-fix/ > > > > DL_NOTE_PHYS_ADDR/DL_CURR_DEST_ADDR is only sent up for datalinks that > > have a destination, and libdlpi drops notifications for address types it > > doesn't know about (which is everything except for DL_CURR_PHYS_ADDR). > > To me, this makes the most sense. > > I'm fine with that, provided that libdlpi is enhanced to have some way to > report DL_CURR_DEST_ADDR indications.
Okay, that's fine, and I can work on that separately. > > > I'm currently in the process of testing this from the IP tunnel > > perspective, and it's fine. This is as expected, as the fix is quite > > unobtrusive to the IP tunnel code. I'd be interested in verifying that > > this fix addresses your original problem (I'd bet money that it does), > > but I don't think we can be completely sure of that until I putback and > > you bringover to your child. Any better ideas? > > That's a fine way to go. Bringing the fix over is easy. Okay, I just putback the fix. As a heads-up, I noticed a number of issues with the ill_token handling in Nevada and the Clearview gate that I'd like to clean up, including a bug in the Clearview gate which causes IPv6 destination link-local addresses to be set incorrectly. Since this is code that you're currently fiddling with in your merge, I'll probably wait until you're done with your merge to putback. Let me know when it would be appropriate to do so. -Seb
