Peter Memishian writes:
> That said, I'm glad you raised this issue because there is indeed a
> problem: canonize_lif() also checks whether IFF_DHCPRUNNING is set, and
> bails if it's not.

Yep.  I should have mentioned that, but I was fixated on the address
as the point of first failure.

>  That check doesn't apply in this case but is useful as
> a sanity-check when canonize_lif() is called from unplumb_lif(), so I've
> added a new argument to canonize_lif() to control its behavior.  I've also
> verified that one can indeed acquire a lease on an ipif with a down but
> non-zero address, and on an ipif that's up but some other value (we don't
> canonize in that case, but it's harmless).

And also that it doesn't nuke an interface used for "inform."

> The webrev has been respun.

Seems good; thanks.

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

Reply via email to