> > > > I've completed my initial testing and self-review, so it's time to > > start > > > > code review for the DHCP client sockets changes. The webrev is at: > > > > > > > > http://cr.opensolaris.org/~meem/dhcp-sock > > > > I've updated the webrev to address all the comments I've received and to > > include the new IP_DHCPINIT_IF implementation (6609852). (Overall, the > > changes are minor.) > > I went back and looked at all of the code again. Here's all that I > found ... just a couple of nits. > > usr/src/uts/common/inet/ip.h > > 1967: nit: for alignment reasons, and just because I like to see new > members at the bottom of the structure, I would have put this after > line 1970. (Note that alignment is 8 after ill_usesrc_grp_next, and > then the next two members are size 4.)
I thought about that, but the blank line at 1968 stopped me -- it seemed to be trying to say "keep ill_ipst last" (but I don't know why that would be necessary). > usr/src/uts/common/inet/ip/ip.c > > 20280: how could connp be NULL here? Wouldn't 20267 catch it? Agreed; I'll fix this. -- meem
