On 4/08/09 01:17 PM, Sebastien Roy wrote: > Darren, > > On Mon, 2009-07-27 at 19:01 -0700, Darren Reed wrote: > >> http://cr.opensolaris.org/~darrenr/onnv-pcapture/ >> >> > > Do you have a cscope database for this code-review repo somewhere to > help with browsing the code? >
Is there a way to upload a cut-down version of that to opensolaris or does this remain a SWAN thing only? /net/nvtbld-x.sfbay/exportz/avalon/on_bpf_pfpacket_review/ btw, in reviewing the code myself, I had some questions about if I should do some renaming in ipnet.c... For example, there is "ipnetif_refhold/ipnetif_refrele" but then there is "ipnet_create_if" and "ipnet_free_if". Also, in some places "ipnetif" is the "local" variable for an ipnetif_t and in others it is "ifp". Whilst seemingly minor, it doesn't feel like it is all the product of a single design? During working on that file, I got annoyed enough with the different code styles used for local variables that I converted them all to be one because otherwise it was not clear to which style new code should be added! And in review, I've come up against the same issue with adding new functions but it has bothered me less. Darren -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/clearview-discuss/attachments/20090804/23f9f07c/attachment.html>
