On Tue, 2009-08-04 at 14:09 -0700, Darren Reed wrote: > On 4/08/09 01:53 PM, Sebastien Roy wrote: > > > > > /net/nvtbld-x.sfbay/exportz/avalon/on_bpf_pfpacket_review/ > > > > > > > > > > Thanks. Could you run xref under usr/src/uts/ as well please? > > > > I've previously only built cscope's for usr/src with "make > cscope.out". > It looks like it should work for uts, but it fails for me?
I usually just type "xref", and that works fine. > > > During working on that file, I got annoyed > > > enough with the different code styles used for local variables > > > that I converted them all to be one because otherwise it was not > > > clear to which style new code should be added! > > > > > > > The style is, and should be (for multiple variables): > > > > <type> <name>; > > <type> <name>; > > > > Where each name is aligned at a common tab-stop. I don't see many > > inconsistencies here, I'm not sure what you're referring to. I'd > > refrain from making sweeping changes to the code style in the file, as > > that detracts from reviewing your actual substantive changes. > > > > There weren't many ... just enough in the wrong places ... > but if that is the style, then that's what I'll use. Great, thanks. -Seb
