Thanks Eddie!
I've run into a couple complications:
1) It looks like there is a logic error in Packet::has_network_header().
I've attached a patch.
2) click-uninstall'ing the kernel module results in a general protection
fault. My configure string is "./configure --enable-multithread
--enable-user-multithread --enable-adaptive --enable-intel-cpu CFLAGS=-g
CXXFLAGS=-g". I am building on an x86_64 machine. The click configuration
used or the number of threads doesn't seem to affect the problem. See
gpf.log for more information.
3) I'm getting warnings when click descends into the kernel source
directory to build the module. See warning.log. My guess is that this is
due to the improved linuxmodule build process.
Polling seems to be working with the e1000-7.6.15.5 driver.
Thanks again,
Kevin Springborn
> Hi all,
>
> Click has been updated with the patch for Linux 2.6.24.7 support; and the
> Linux 2.6.24.7 patch has been checked into the Click repository. Please
> let
> us know if all of this works. I would love to hear working or not working
> reports from users.
>
> Thanks very much to, especially, Adam Greenhalgh, Joonwoo Park, and Nemean
> Networks for putting together this patch.
>
> Thanks,
> Eddie
> _______________________________________________
> click mailing list
> [email protected]
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>
--- a/include/click/packet.hh 2008-10-29 12:43:11.000000000 -0500
+++ b/include/click/packet.hh 2008-10-29 12:43:46.000000000 -0500
@@ -930,7 +930,7 @@
#if CLICK_LINUXMODULE
# if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 24)
# if NET_SKBUFF_DATA_USES_OFFSET
- return skb()->network_header == ~0U;
+ return skb()->network_header != ~0U;
# else
return skb()->network_header != 0;
# endif../click-buildtool elem2export < elements.conf > elements.cc
make[2]: Entering directory `/usr/src/kernel-2.6.24.7'
CC [M] crc32.o
CC [M] in_cksum.o
CXX [M] string.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] straccum.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] nameinfo.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] bitvector.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] vectorv.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] templatei.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] bighashmap_arena.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] ipaddress.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] ipflowid.o
cc1plus: warning: command line option "-Werror-implicit-function-declaration" is valid for C/ObjC but not for C++
CXX [M] etheraddress.o
click: stopping router thread pid 2991
click: stopping router thread pid 2990
click: stopping router thread pid 2989
poll ffffffff884f2f00: 1/0 freed, 0/0 allocated
poll ffffffff884f3318: 4/0 freed, 0/0 allocated
click module exiting
general protection fault: 0000 [2] SMP
CPU 0
Modules linked in: proclikefs <snip>
Pid: 3011, comm: click-uninstall Tainted: PF D 2.6.24.7 #6
RIP: 0010:[<ffffffff80257ffb>] [<ffffffff80257ffb>] module_put+0x17/0x32
RSP: 0018:ffff8100164ebe38 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff810015440848 RCX: 0000000000000004
RDX: ffffffff8029ae7f RSI: 0000000000000001 RDI: 6b6b6b6b6b6b6b6b
RBP: ffff8100164ebe38 R08: ffffe2000157ae80 R09: ffff810015440848
R10: 0000000000000002 R11: ffffe2000157ae80 R12: ffff810039583000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
FS: 00002b72724f5d30(0000) GS:ffffffff80610000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 000000000063f228 CR3: 0000000015d03000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process click-uninstall (pid: 3011, threadinfo ffff8100164ea000, task ffff8100060c0000)
Stack: ffff8100164ebe48 ffffffff802ae068 ffff8100164ebe68 ffffffff8029af22
ffff810015440848 ffff81003e229dc0 ffff8100164ebe88 ffffffff802aec4e
ffff8100164ebeb8 ffff810015440848 ffff8100164ebea8 ffffffff8029feee
Call Trace:
[<ffffffff802ae068>] put_filesystem+0xd/0xf
[<ffffffff8029af22>] deactivate_super+0x77/0x84
[<ffffffff802aec4e>] mntput_no_expire+0x59/0x98
[<ffffffff8029feee>] path_release_on_umount+0x1d/0x21
[<ffffffff802af54a>] sys_umount+0x242/0x288
[<ffffffff80484dbc>] lockdep_sys_exit_thunk+0x35/0x67
[<ffffffff8027d41b>] handle_mm_fault+0x65a/0x705
[<ffffffff80484d4b>] trace_hardirqs_on_thunk+0x35/0x3a
[<ffffffff8027d41b>] handle_mm_fault+0x65a/0x705
[<ffffffff8020c07e>] system_call+0x7e/0x83
Code: 48 ff 8c 38 c0 01 00 00 83 3f 02 75 0c 48 8b bf 90 41 00 00
RIP [<ffffffff80257ffb>] module_put+0x17/0x32
RSP <ffff8100164ebe38>
---[ end trace 3fab88371e96185a ]---
[EMAIL PROTECTED] click-install]# ./click-uninstall -V
click-uninstall: Installing blank configuration in kernel
click-uninstall: Removing Click module
click-uninstall: Unmounting Click filesystem at /click
Segmentation fault
[EMAIL PROTECTED] click-install]#
Message from syslogd@ at Wed Oct 29 11:50:36 2008 ...
localhost kernel: general protection fault: 0000 [2] SMP
_______________________________________________
click mailing list
[email protected]
https://amsterdam.lcs.mit.edu/mailman/listinfo/click
