Re: [Click] Linux 2.6.24.7 patch in

springbo Wed, 29 Oct 2008 14:35:12 -0700

Hi Eddie,

Thanks for the fixes.


I ran with the previous version of proclikefs.c and still had the same
problem.

I did a little poking into what is going on:
*proclikefs_put_super(struct super_block *sb) is returning cleanly.
*local_dec(&module->ref[cpu].count) in kernel/module.c::module_put is what
is causing the fault
*It seems like http://lkml.org/lkml/2007/3/21/332 might have had the same
problem.

When powering off after the click-uninstall GPF I got a 'Poison
overwritten' message. I'm not sure if this has to do with the GPF or if
this is simply a reincarnation of the list_del corruption from a while
back (https://pdos.csail.mit.edu/pipermail/click/2007-March/005746.html)

Sorry I can't be of more help,
Kevin





> Hi Kevin, thanks very much for checking this out!
>
> [EMAIL PROTECTED] wrote:
>> Thanks Eddie!
>>
>> I've run into a couple complications:
>> 1) It looks like there is a logic error in Packet::has_network_header().
>> I've attached a patch.
>
> Yep, oops.  has_transport_header() was also wrong; both are fixed.
>
>> 2) click-uninstall'ing the kernel module results in a general protection
>> fault. My configure string is  "./configure --enable-multithread
>> --enable-user-multithread --enable-adaptive --enable-intel-cpu CFLAGS=-g
>> CXXFLAGS=-g". I am building on an x86_64 machine. The click
>> configuration
>> used or the number of threads doesn't seem to affect the problem. See
>> gpf.log for more information.
>
> This is a little worrisome.  I wonder if the problem here was related to
>
> http://read.cs.ucla.edu/gitweb?p=click;a=commit;h=f72c997281d970ef6fc1cf94feefc23125c31e20
>
> Do you have a version of proclikefs.c as created by the prior patch?  If
> so,
> does unloading work with that proclikefs?
>
>> 3) I'm getting warnings when click descends into the kernel source
>> directory to build the module. See warning.log. My guess is that this is
>> due to the improved linuxmodule build process.
>
> I reenabled the relevant part of Joonwoo's patch.
>
>> Polling seems to be working with the e1000-7.6.15.5 driver.
>
> Cool!
>
> Eddie
>
>
>> Thanks again,
>> Kevin Springborn
>>
>>
>>
>>
>>> Hi all,
>>>
>>> Click has been updated with the patch for Linux 2.6.24.7 support; and
>>> the
>>> Linux 2.6.24.7 patch has been checked into the Click repository.
>>> Please
>>> let
>>> us know if all of this works.  I would love to hear working or not
>>> working
>>> reports from users.
>>>
>>> Thanks very much to, especially, Adam Greenhalgh, Joonwoo Park, and
>>> Nemean
>>> Networks for putting together this patch.
>>>
>>> Thanks,
>>> Eddie
>>> _______________________________________________
>>> click mailing list
>>> [email protected]
>>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>>>
>

BUG kmalloc-256: Poison overwritten
-----------------------------------------------------------------------------

INFO: 0xffff81003c59b178-0xffff81003c59b187. First byte 0x78 instead of 0x6b
INFO: Allocated in proclikefs_register_filesystem+0xea/0x23a [proclikefs] age=25747 cpu=0 pid=2330
INFO: Freed in proclikefs_put_super+0xab/0xbb [proclikefs] age=24606 cpu=0 pid=2336
INFO: Slab 0xffffe200016a1a20 used=4294967295 fp=0xffff81003c59b8f8 flags=0x38080000000002
INFO: Object 0xffff81003c59b148 @offset=328 fp=0xffff81003c59b290

Bytes b4 0xffff81003c59b138:  28 c0 ff ff 00 00 00 00 5a 5a 5a 5a 5a 5a 5a 5a (ï¿½ï¿½ï¿½....ZZZZZZZZ
  Object 0xffff81003c59b148:  6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
  Object 0xffff81003c59b158:  6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
  Object 0xffff81003c59b168:  6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
  Object 0xffff81003c59b178:  78 b1 59 3c 00 81 ff ff 78 b1 59 3c 00 81 ff ff xï¿½Y<..ï¿½ï¿½xï¿½Y<..ï¿½ï¿½
  Object 0xffff81003c59b188:  6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
  Object 0xffff81003c59b198:  6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
  Object 0xffff81003c59b1a8:  6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
  Object 0xffff81003c59b1b8:  6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
 Redzone 0xffff81003c59b248:  bb bb bb bb bb bb bb bb                         ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½        
 Padding 0xffff81003c59b288:  5a 5a 5a 5a 5a 5a 5a 5a                         ZZZZZZZZ        
Pid: 9, comm: events/0 Tainted: P      D 2.6.24.7 #6

Call Trace:
 [<ffffffff802915d7>] print_trailer+0x15a/0x163
 [<ffffffff80291684>] check_bytes_and_report+0xa4/0xcb
 [<ffffffff8029193f>] check_object+0xca/0x20c
 [<ffffffff80291cad>] __free_slab+0x6d/0xf2
 [<ffffffff802fa9fd>] key_user_put+0x46/0x4b
 [<ffffffff80291d7c>] discard_slab+0x4a/0x4c
 [<ffffffff80291f9b>] __slab_free+0x10f/0x311
 [<ffffffff802fa9fd>] key_user_put+0x46/0x4b
 [<ffffffff8029306c>] kfree+0xc9/0xf0
 [<ffffffff802fb0a7>] key_cleanup+0x0/0x12b
 [<ffffffff802fb0a7>] key_cleanup+0x0/0x12b
 [<ffffffff802fa9fd>] key_user_put+0x46/0x4b
 [<ffffffff802fb1a0>] key_cleanup+0xf9/0x12b
 [<ffffffff802414a0>] run_workqueue+0xee/0x1f6
 [<ffffffff80242098>] worker_thread+0x99/0xa6
 [<ffffffff802453cb>] autoremove_wake_function+0x0/0x38
 [<ffffffff80241fff>] worker_thread+0x0/0xa6
 [<ffffffff802452a7>] kthread+0x49/0x76
 [<ffffffff8020cfb8>] child_rip+0xa/0x12
 [<ffffffff8020c6cf>] restore_args+0x0/0x30
 [<ffffffff8024525e>] kthread+0x0/0x76
 [<ffffffff8020cfae>] child_rip+0x0/0x12

FIX kmalloc-256: Restoring 0xffff81003c59b178-0xffff81003c59b187=0x6b

_______________________________________________
click mailing list
[email protected]
https://amsterdam.lcs.mit.edu/mailman/listinfo/click

Re: [Click] Linux 2.6.24.7 patch in

Reply via email to