On Thu, 9 Sep 2021 16:50:56 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Times has been the hard coded name for Serif in the JDK sources for macOS >> since the port was contributed by Apple. >> But it seems that macOS Monterey doesn't have this font. >> And the hard-coded fallback is also Times ! So we end up returning Dialog >> which is very bad. >> >> The safest fix here is to make Times New Roman the fall back, so that on >> older macOS versions there >> is absolutely no change. Only on Monterey and presumably later, will it use >> Times New Roman which, >> I suspect, is what Times actually ends up being anyway. >> >> Also to prevent unconditional warnings being printed I needed to change >> those to be conditional on logging being set. > > test/jdk/java/awt/FontClass/LogicalFontsTest.java line 28: > >> 26: * @bug 8273358 >> 27: * @summary Verify logical fonts are as expected. >> 28: * @run main/othervm LogicalFontsTest > > Is othervm option needed as we are not setting new paramter in command line? Not strictly since we configure the top level test directory to use othervm but I did it consciously since it is best that such tests run in a brand new VM ------------- PR: https://git.openjdk.java.net/jdk/pull/5420
