On Wed, 8 Sep 2021 16:49:26 GMT, Phil Race <[email protected]> wrote:

> Times has been the hard coded name for Serif in the JDK sources for macOS 
> since the port was contributed by Apple.
> But it seems that macOS Monterey doesn't have this font.
> And the hard-coded fallback is also Times ! So we end up returning Dialog 
> which is very bad.
> 
> The safest fix here is to make Times New Roman the fall back, so that on 
> older macOS versions there
> is absolutely no change. Only on Monterey and presumably later, will it use 
> Times New Roman which,
> I suspect, is what Times actually ends up being anyway.
> 
> Also to prevent unconditional warnings being printed I needed to change those 
> to be conditional on logging being set.

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5420

Reply via email to