On Fri, 10 Sep 2021 15:11:20 GMT, Artem Semenov 
<github.com+36081106+savop...@openjdk.org> wrote:

> We've extended the current implementation of TableAccessibility to make sure 
> that individual cells are voiced when navigating with the keyboard.

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ColumnAccessibility.m line 
52:

> 50: }
> 51: 
> 52: - (NSArray *)accessibilityChildren

Could you please clarify why you removed this method?

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableAccessibility.m line 
223:

> 221: 
> 222: - (id)accessibilityCellForColumn:(NSInteger)column row:(NSInteger)row {
> 223:     return [[(TableRowAccessibility *)[[self accessibilityRows] 
> objectAtIndex:row] accessibilityChildren] objectAtIndex:column];

This implementation is inefficient. You're creating an instance per each row in 
the table (think about long tables) just for taking a single row. Same for 
columns.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5466

Reply via email to