On Mon, 13 Sep 2021 14:47:30 GMT, Anton Tarasov <[email protected]> wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8271071 accessibility of a table on macOS lacks cell navigation
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ColumnAccessibility.m
> line 52:
>
>> 50: }
>> 51:
>> 52: - (NSArray *)accessibilityChildren
>
> Could you please clarify why you removed this method?
As the analysis of the a11y table hierarchy in numbers showed, this object has
no children. From which I conclude that the columns should not have children.
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableAccessibility.m
> line 223:
>
>> 221:
>> 222: - (id)accessibilityCellForColumn:(NSInteger)column row:(NSInteger)row {
>> 223: return [[(TableRowAccessibility *)[[self accessibilityRows]
>> objectAtIndex:row] accessibilityChildren] objectAtIndex:column];
>
> This implementation is inefficient. You're creating an instance per each row
> in the table (think about long tables) just for taking a single row. Same for
> columns.
done
-------------
PR: https://git.openjdk.java.net/jdk/pull/5466
