On Tue, 9 Nov 2021 17:49:04 GMT, Ludvig Janiuk <d...@openjdk.java.net> wrote:
>> This change introduces no visual difference, but improves a11y.
>
> Ludvig Janiuk has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Achieve correct row headers without header change
I'm fine with the 2nd version yet I'm pretty DocChecker won't be happy unless
you create additional row header with `<th>` element.
Shall the third column of the table be converted to `<th>` to compensate for
that?
src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 117:
> 115: * <th scope="col" id="colheader1">Unicode Range
> 116: * <th scope="col" id="colheader2">{@code NumericShaper} Constants
> 117: * <th scope="col" id="colheader3">Precedence
Shall we use more descriptive ids?
Suggestion:
* <th scope="col" id="nsUnicodeRangeHeader">Unicode Range
* <th scope="col" id="nsConstantsHeader">{@code NumericShaper} Constants
* <th scope="col" id="nsPrecedence">Precedence
src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 132:
> 130: * <td headers="rowheader1 colheader3">{@link
> NumericShaper.Range#EASTERN_ARABIC}
> 131: * <tr>
> 132: * <th scope="row">Tai Tham
Does it make sense to use `<th scope="rowgroup">` for consistency?
src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 133:
> 131: * <td>{@link NumericShaper.Range#EASTERN_ARABIC}
> 132: * </tbody>
> 133: * <tbody>
You need to preserve both `<tbody>` to have two row groups.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6291
