On Wed, 10 Nov 2021 11:04:54 GMT, Ludvig Janiuk <d...@openjdk.java.net> wrote:
>> src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 117:
>>
>>> 115: * <th scope="col" id="colheader1">Unicode Range
>>> 116: * <th scope="col" id="colheader2">{@code NumericShaper} Constants
>>> 117: * <th scope="col" id="colheader3">Precedence
>>
>> Shall we use more descriptive ids?
>> Suggestion:
>>
>> * <th scope="col" id="nsUnicodeRangeHeader">Unicode Range
>> * <th scope="col" id="nsConstantsHeader">{@code NumericShaper} Constants
>> * <th scope="col" id="nsPrecedence">Precedence
>
> Not relevant anymore given last change
Why is it not relevant? You're still using the ids?
I see you've removed the `header` attribute but I still `id` attributes. Will
you be removing the id attributes too?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6291
