On Mon, 21 Feb 2022 12:53:35 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Emmanuel Bourg has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Test case for the window icon update on DPI change (other changes) >> - Test case for the window icon update on DPI change (@compile not needed) >> - Test case for the window icon update on DPI change (center the frame) >> - Test case for the window icon update on DPI change (specific message for >> timeouts) >> - Test case for the window icon update on DPI change (icon with a white >> background and centered text) > > test/jdk/java/awt/Window/WindowIconUpdateOnDPIChanging/WindowIconUpdateOnDPIChangingTest.java > line 98: > >> 96: frame.getContentPane().add(createInstrumentsPane(), >> BorderLayout.CENTER); >> 97: frame.getContentPane().add(createControlPanel(), >> BorderLayout.SOUTH); >> 98: frame.setIconImages(IntStream.rangeClosed(16, 32).mapToObj(size >> -> createIcon(size)).toList()); > > In fact, I liked the version with method reference better even though the > line is longer. > > But I still suggest wrapping the line at each dot to make it clearer what > operations are performed on the stream. > Suggestion: > > frame.setIconImages(IntStream.rangeClosed(16, 32) > .mapToObj(size -> createIcon(size)) > .toList()); > > It fits into 80 column limit. If it's replaced with method reference as it > was before, it doesn't fit but I don't see it as big problem. > > Alternatively, you can wrap the start of the stream too: > Suggestion: > > frame.setIconImages( > IntStream.rangeClosed(16, 32) > > .mapToObj(WindowIconUpdateOnDPIChangingTest::createIcon) > .toList()); > > The line with method reference takes 82 columns, I'm sure it's acceptable. Here, on GitHub the lines in the suggestion could be wrapped, the idea is that the dots `.` of the following method calls remain aligned. ------------- PR: https://git.openjdk.java.net/jdk/pull/6180
