On Mon, 21 Feb 2022 12:45:42 GMT, Alexey Ivanov <[email protected]> wrote:
>> Emmanuel Bourg has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Test case for the window icon update on DPI change (other changes)
>> - Test case for the window icon update on DPI change (@compile not needed)
>> - Test case for the window icon update on DPI change (center the frame)
>> - Test case for the window icon update on DPI change (specific message for
>> timeouts)
>> - Test case for the window icon update on DPI change (icon with a white
>> background and centered text)
>
> test/jdk/java/awt/Window/WindowIconUpdateOnDPIChanging/WindowIconUpdateOnDPIChangingTest.java
> line 79:
>
>> 77:
>> SwingUtilities.invokeLater(WindowIconUpdateOnDPIChangingTest::createUI);
>> 78: if (!countDownLatch.await(15, TimeUnit.MINUTES)) {
>> 79: frame.dispose();
>
> It must be called on EDT.
> Suggestion:
>
> SwingUtilities.invokeAndWait(() -> frame.dispose());
That's just a test, do we really need this level of refinement?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6180
