On Thu, 3 Mar 2022 22:51:48 GMT, DamonGuy <d...@openjdk.java.net> wrote:

>> Html does not fit in JButton at certain sizes because default Insets cause 
>> html to be displayed off-center. 
>> 
>> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable 
>> clipping if html does not fit, similar to regular text. AquaButtonUI.java 
>> now detects when html does not fit, and an implementation for alternate 
>> insets that are recursively tested for regular text inside 
>> layoutAndGetText() are now also being used for html content.
>> 
>> Created test (Bug8015854.java) with the same format as the test described on 
>> the issue. The button is of size 37x37 with an image of a red square sized 
>> 19x19. The test checks for red pixels on the edges of where the square image 
>> should be from the center of the button. The test fails with the non-changed 
>> jdk, but passes with the changes.
>
> DamonGuy has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Changed method name.
>  - Reorganized imports. Added space in conditional.

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7310

Reply via email to