On Mon, 14 Mar 2022 12:54:00 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> formatting changes to test case > > src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 1192: > >> 1190: >> 1191: //create and return Color corresponding to new hsbValues >> 1192: return Color.getHSBColor(hsbValues[0], hsbValues[1], >> hsbValues[2]); > > It seems you are only manipulating hue and saturation, not the brightness > which is set to 1.0f throughout..need to change the javadoc comment Sure. I will change the Javadocs comments as suggested. The reason for setting brightness to max value is that for any color returned by hue and saturation offset, setting brightness=1 gives the brightest color for the new color used for cell highlighting purpose. ------------- PR: https://git.openjdk.java.net/jdk/pull/7768
