Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

[Prasanta Sadhukhan]

On Mon, 28 Mar 2022 19:37:28 GMT, Harshitha Onkar <d...@openjdk.java.net> wrote:

>> In my testing in osx10.15 with your fix, I see focus ring is following 
>> highlight color and not accent color...did you modify anything in your fix?
>> <img width="688" alt="Screenshot 2022-03-28 at 11 52 09 AM" 
>> src="https://user-images.githubusercontent.com/43534309/160338556-117c8e9b-4e78-4368-8040-dfca1d82e1ab.png";>
>
> @prsadhuk I have pushed latest changes related to AquaLookAndFeel.java file 
> only. The CSystemColors.m is not checked-in because of 
> [selectedContentBackgroundColor](https://developer.apple.com/documentation/appkit/nscolor/2998830-selectedcontentbackgroundcolor)
>  type property build issues. 
> 
> 
>> In my testing in osx10.15 with your fix, I see focus ring is following 
>> highlight color and not accent color...did you modify anything in your fix? 
>> <img alt="Screenshot 2022-03-28 at 11 52 09 AM" width="688" 
>> src="https://user-images.githubusercontent.com/43534309/160338556-117c8e9b-4e78-4368-8040-dfca1d82e1ab.png";>
> 
> For this scenario, wanted to verify if the **selectionBackground** explicitly 
> set to green in AquaLookAndFeel?

With latest repo and your fix, I put a debug log in deriveContrastFocusRing() 
and it seems to produce this output (for scenario above)

selectedBackgroundColor 
com.apple.laf.AquaImageFactory$SystemColorProxy[r=54,g=128,b=34]

I see, even if I change the highlight Color to blue, it does not call 
deriveContrastFocusRing() again and the focus ring remains green although 
background Color of JTable cell changes to blue

<img width="537" alt="Screenshot 2022-03-29 at 12 49 59 PM" 
src="https://user-images.githubusercontent.com/43534309/160556234-cf1732f3-57bd-4530-82e6-e2080e9e1551.png";>
.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7768