On Fri, 22 Apr 2022 08:38:09 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> Alisen Chung has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Merge branch '7080150' of github.com:alisenchung/jdk into 7080150
>>  - fixed merge conflict
>
> test/jdk/java/awt/regtesthelpers/UtilInternal.java line 81:
> 
>> 79:             Method get_target = window_peer_class.getMethod("getTarget", 
>> new Class[0]);
>> 80:             System.out.println("get_target = " + get_target);
>> 81:             return (Frame) get_target.invoke(frame_peer, new Object[0]);
> 
> Shouldn't we invoke sun/lwawt/macosx/CEmbeddedFrame same as we do for 
> windows/linux via WEmbeddedFrame and XEmbeddedFrame?

CEmbeddedFrame doesn't have a way to pass in a handle like in WEmbeddedFrame 
and XEmbeddedFrame, so I can't pass in the peer's target. If I try to use 
CEmbeddedFrame the test window will pop up but the EmbeddedFrame won't show up 
and the test fails

-------------

PR: https://git.openjdk.java.net/jdk/pull/8348

Reply via email to