On Fri, 22 Apr 2022 17:49:26 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> test/jdk/java/awt/regtesthelpers/UtilInternal.java line 81:
>>
>>> 79: Method get_target =
>>> window_peer_class.getMethod("getTarget", new Class[0]);
>>> 80: System.out.println("get_target = " + get_target);
>>> 81: return (Frame) get_target.invoke(frame_peer, new Object[0]);
>>
>> Shouldn't we invoke sun/lwawt/macosx/CEmbeddedFrame same as we do for
>> windows/linux via WEmbeddedFrame and XEmbeddedFrame?
>
> CEmbeddedFrame doesn't have a way to pass in a handle like in WEmbeddedFrame
> and XEmbeddedFrame, so I can't pass in the peer's target. If I try to use
> CEmbeddedFrame the test window will pop up but the EmbeddedFrame won't show
> up and the test fails
Are you sure that CEmbeddedFrame is used in the embedding functionality? We
have another one on macOS CViewEmbeddedFrame. One of them was used for applets
another one was used by the JAWT and SWT. Please double-check that the correct
one is used for this test, and another one probably can be removed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8348
