On Tue, 26 Apr 2022 19:42:05 GMT, DamonGuy <d...@openjdk.java.net> wrote:
> The insets for buttons were incorrect for L&Fs except for Aqua when the text > is set to HTML. This was fixed in Aqua by adding a conditional to check for > the BasicHTML property key in the button component. This same logic can be > used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus is not fixed by > this. Nimbus gets its default values from a skin.laf file, and when the > defaults here are set to have left & right insets to 0 for ButtonUI, the > issue is fixed. I also tested for non-HTML text after the changes, and the > changes do not affect normal text. > > The HtmlButtonImageTest has been changed to cycle through all L&Fs available > on a device. src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 271: > (failed to retrieve contents of file, check the PR for context) > I also tested for non-HTML text after the changes, and the changes do not > affect normal text. And this is true for this Nimbus case too ? Whereas your code update in BasicButtonUI is checking for HTML, I don't see how it could *not* change normal text in the Nimbus case. ------------- PR: https://git.openjdk.java.net/jdk/pull/8407
