On Tue, 10 May 2022 19:03:23 GMT, DamonGuy <d...@openjdk.java.net> wrote:
>> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus is not fixed by >> this. Nimbus gets its default values from a skin.laf file, and when the >> defaults here are set to have left & right insets to 0 for ButtonUI, the >> issue is fixed. I also tested for non-HTML text after the changes, and the >> changes do not affect normal text. >> >> The HtmlButtonImageTest has been changed to cycle through all L&Fs available >> on a device. > > DamonGuy has updated the pull request incrementally with one additional > commit since the last revision: > > Added string buffer. Separated fail images. Changed exception to throw at > the end of test. Marked as reviewed by psadhukhan (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/8407
