On Wed, 11 May 2022 18:01:27 GMT, Alexey Ivanov <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test updated
>
> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 63:
>
>> 61: + " Test cannot continue.");
>> 62: PassFailJFrame.forcePass();
>> 63: }
>
> This could be the first statements in main, as you don't even need to show
> the instructions in this case.
ok. done
> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 69:
>
>> 67: });
>> 68:
>> 69: Thread.sleep(1000);
>
> The delay is not required here.
ok
> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 80:
>
>> 78: try {
>> 79: if (!table.print()) {
>> 80: throw new RuntimeException("Printing cancelled");
>
> When run outside of jtreg, this exception doesn't stop the test. In jtreg, it
> does.
>
> So it works as expected when run in jtreg but it could be confusing if run as
> a stand-alone test.
I amnot sure if anyone will try to run it outside jtreg as it has dependancy on
jtreg helper class PassFailJFrame
but anyway I have tried to address the concern.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8141
