On Wed, 25 May 2022 14:19:49 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> It is a problem for jtreg tests: `System.exit` shouldn't be called. We >> should not use it for new tests even if there are tests which use it. >> >> `DISPOSE_ON_CLOSE` is fine: it disposes of the frame; once there are no >> frames left, the JVM exits. >> >> For this test, `DO_NOTHING_ON_CLOSE` could also work well. After all, the >> user is not expected to interact with the secondary frame at all. > > I dont think it is a problem now..As the tests are now run in othervm mode > and not in samevm mode as we used to do pre2018.. > there's a comment on this aspect too > https://github.com/openjdk/jdk/pull/8293#discussion_r854488853 > > ANyway, I have removed the contentious call That's right. _“it is still fine to fix this.”_ ------------- PR: https://git.openjdk.java.net/jdk/pull/8141
