On Tue, 10 May 2022 19:52:41 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > renamed test, renamed some methods, updated error messages, updated test [As discussed](https://github.com/openjdk/jdk/pull/8441#pullrequestreview-972614622) in #8441, the changes to `TitledBorder.java` should be reverted as unrelated. src/java.desktop/share/classes/javax/swing/border/EtchedBorder.java line 162: > 160: ((Graphics2D) g).setTransform(new AffineTransform()); > 161: oldStk = ((Graphics2D) g).getStroke(); > 162: stkWidth = (int) > Math.floor(Math.min(at.getScaleX(),at.getScaleY())); Suggestion: stkWidth = (int) Math.floor(Math.min(at.getScaleX(), at.getScaleY())); src/java.desktop/share/classes/javax/swing/border/EtchedBorder.java line 178: > 176: w, h, stkWidth); > 177: paintBorderHighlight(g, (etchType == LOWERED) ? getShadowColor(c) > 178: : > getHighlightColor(c), After you updated the name of the method, `:` isn't aligned to `?`. test/jdk/java/awt/TitledBorder/ScaledEtchedBorderTest.java line 112: > 110: boolean checkHighlight = false; > 111: for (int x = 0; x < img.getWidth(); x++) { > 112: int color = img.getRGB(x,y); Suggestion: int color = img.getRGB(x, y); test/jdk/java/awt/TitledBorder/ScaledEtchedBorderTest.java line 158: > 156: boolean checkHighlight = false; > 157: for (int y = 0; y < img.getHeight(); y++) { > 158: int color = img.getRGB(x,y); Suggestion: int color = img.getRGB(x, y); ------------- Changes requested by aivanov (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7449
