On Tue, 17 May 2022 20:18:33 GMT, Phil Race <p...@openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   renamed test, renamed some methods, updated error messages, updated test
>
> test/jdk/java/awt/TitledBorder/ScaledEtchedBorderTest.java line 237:
> 
>> 235:         } else {
>> 236:             frame.dispose();
>> 237:         }
> 
> That looks odd. I mean if you show the frame, how is it disposed ?
> 
> And more broadly ... why do you even create the frame if you never show it ?
> And if you don't create the frame, this test can be headless, can't it ?

Perhaps you are trying to get layout to happen ? That should be possible but it 
might be tricky.
But I think if you are going so far as pack() and can't change that, then show 
the frame regardless.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7449

Reply via email to