On Wed, 1 Jun 2022 18:00:44 GMT, Phil Race <p...@openjdk.org> wrote:

> > > > Shall the test be located in 
> > > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of 
> > > > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > > Usually, there's been a folder with bugid (`/4380543/`) for each test. 
> > > > Do we use the flat layout now?
> > > 
> > > 
> > > @aivanov-jdk Recently we have started to use the latter and remove the 
> > > extra folder (`/4380543/`)
> > 
> > 
> > Thank you for clarification, Harshitha.
> 
> Yes, blame (?) me :-) We may not always remember to point it out but it is 
> what we want. I've never seen the point in an extra level of folder except 
> when the test is composed of multiple files all unique to the test. I also 
> request that new tests not be given names like bug87654321.java but instead 
> be named in a way that you can tell what they are supposed to be testing like 
> in this case something like RadioButtonMarginTest.java

Sure @prrace , will rename the test. Harshitha also suggested that previously, 
I thought of retaining for this test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721

Reply via email to