On Thu, 2 Jun 2022 15:32:11 GMT, Tejesh R <t...@openjdk.org> wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed whitespaces
Except for the minor comments, it looks good now.
test/jdk/javax/swing/JRadioButton/bug4380543.java line 59:
> 57: Verify only with those L&F where Margin is Visible.
> 58: 3. If Left insets(margins) appear Empty, press Fail,
> 59: else press Pass.
Suggestion:
1. Check if the Left inset(margin) is set visually
similar to other three sides around Radio Button
and CheckBox (insets set to 20 on all 4 sides).
2. Rendering depends on OS and supported Look and Feels.
Verify only with those L&F where margins are visible.
3. If Left inset(margin) appears too small, press Fail,
else press Pass.
I think _left inset_ or _margin_ is better — it's one instance.
You may want to add an additional space to all the lines without numbers to
visually align the text to the start of the text after the number. I assume
this is why you have an extra space before ‘and’.
test/jdk/javax/swing/JRadioButton/bug4380543.java line 83:
> 81:
> 82: class testFrame extends JFrame implements ActionListener {
> 83: public testFrame() {
Class names should start with a capital letter.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8721
