On Tue, 7 Jun 2022 10:47:25 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Updated based on review comments
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 72:
> 
>> 70:                     //Adding the Test Frame to handle dispose
>> 71:                     passFailJFrame.addTestFrame(testObj);
>> 72:                     passFailJFrame.positionTestFrame(testObj, 
>> PassFailJFrame.Position.HORIZONTAL);
> 
> This was correct: you're calling static methods; such methods should not be 
> called _via an instance variable_ but via the class name. Alternatively, you 
> can static-import these methods.

I think it wouldn't make any difference calling static methods via an instance 
variable or directly with class name.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721

Reply via email to