On Tue, 28 Jun 2022 20:30:36 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Currently PassFailJFrame.positionTestFrame() and >> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been >> changed to Window. >> >> Refactored the above method names to reflect the functionality & input >> parameter type - >> addTestWindow(), positionTestWindow() >> >> Additionally added test fail reason to `forceFail()` to avoid NPE. >> >> Benefits of the change - >> >> - Since Window is a parent class, this would allow the test frame to be a >> Window/Frame/Dialog and not be restricted to a Frame. >> - Code reusability - no need to have separate methods to manage Frame and >> Window >> - Additionally it would allow proper clean-up of window and its container >> subclasses which are added to the PassFailJFrame. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > method doc changes test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 319: > 317: failed = true; > 318: testFailedReason = "Failure Reason:\n" + > 319: "Test force failed"; Maybe _"forceFail called"_? ------------- PR: https://git.openjdk.org/jdk/pull/9300
