On Wed, 3 Aug 2022 13:10:15 GMT, Alexey Ivanov <[email protected]> wrote:
>> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix : Updated to handle multiSelection case >> - Manual Test Indicator Added in JTREG tag > > test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java line 64: > >> 62: >> 63: robot.delay(2000); >> 64: robot.waitForIdle(); > > Robot is not required. You can safely remove these two lines. > > The following line just starts to wait for the user to press `Pass` or `Fail`. > It does not work. > > In the single-selection case, I see the following output: > > ``` > Absolute Path : null > Absolute Path : C:\filechooser\link > ``` > > Above, `null` corresponds to `C:\filechooser\target` folder which is the > target of the `link`. > > Neither does it work in the multi-selection case: > > ``` > Absolute Path : C:\filechooser > Absolute Path : null > Absolute Path : C:\filechooser\target > ``` > > But now it doesn't work in a different way: `link` is reported as `null`. > > I can't see none of the comments addressed in the test even though you > explicitly added comments that you updated the code. A missing push? Yeah, sorry for that, I had missed to push the updates. ------------- PR: https://git.openjdk.org/jdk/pull/9597
