On Wed, 3 Aug 2022 15:14:08 GMT, Alexey Ivanov <[email protected]> wrote:

>> Tejesh R has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Added Dialog information for printing Absolute path
>>  - Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java line 99:
> 
>> 97:                     JOptionPane.showMessageDialog(null, 
>> evt.getNewValue(),
>> 98:                             "Absolute path",
>> 99:                             JOptionPane.INFORMATION_MESSAGE);
> 
> I don't think it is a good idea. For each selection, the tester will get a 
> modal dialog box with the path. It could even prevent the tester from 
> navigating directories for testing.
> 
> I suggest adding a `JListBox` or `JTextArea` on top or bottom of the 
> `JFileChooser` and add the messages there.

Can use JLabel and keep updating(remove the old value and show path which is 
clicked) it right......? Storing previous paths are not required anyhow.

-------------

PR: https://git.openjdk.org/jdk/pull/9597

Reply via email to