> On Windows, the insets obtained for a Non-Resizable AWT Frame was different > when frame.pack() was called and subsequent call to frame.getInsets() or > frame.getPreferredSize(). Due to this, the actual and preferred size differed > when frame.pack() was called for Non-Resizable frame (on Windows). > > Earlier the insets returned when frame.getInsets() was called, was that of a > Resizable frame and not the correct insets associated with Non-Resizable > frame. Fix is added to native code to get the correct insets. The test - > AwtFramePackTest.java has been updated to test actual and expected/preferred > size for both Resizable and Non-Resizable Frames. > > The test is generic though the issue and fix is on Windows platform because > the condition > `frame.getSize() == frame.getPreferredSize()` should be true on all platforms > when frame.pack() is called. > > Following is the link to Windows System Metrics (used for native insets) - > https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsystemmetrics
Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into NonResize_8288325 - Non-Resizable AWT Frame insets fix ------------- Changes: - all: https://git.openjdk.org/jdk/pull/9954/files - new: https://git.openjdk.org/jdk/pull/9954/files/63bacba0..04c26764 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9954&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9954&range=00-01 Stats: 103852 lines in 1920 files changed: 48811 ins; 42648 del; 12393 mod Patch: https://git.openjdk.org/jdk/pull/9954.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9954/head:pull/9954 PR: https://git.openjdk.org/jdk/pull/9954
