On Fri, 30 Sep 2022 10:57:37 GMT, Tejesh R <t...@openjdk.org> wrote: >> When a custom `FileView` is used and folder traversal is restricted to a >> particular directory NPE occurs when user tries to traverse/select other >> folders except traversable folder. This is caused because when user selects >> folder other than traversable, the traversal is rejected and hence no file >> is selected as `currentDirectory` of `JFileChooser`. When user tries to >> access the restricted folder second time, previous selected file check is >> failing because of NPE since `getFileChooser().getCurrentDirectory();` is >> null. To fix the issue, NPE check is added. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated based on review comments
test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 40: > 38: * @bug 6616245 > 39: * @key headful > 40: * @requires (os.family == "windows" | os.family == "linux") Is there a specific reason to exclude macOS? Is it only because the default L&F isn't Metal? ------------- PR: https://git.openjdk.org/jdk/pull/10485
