On Tue, 4 Oct 2022 08:06:24 GMT, Tejesh R <t...@openjdk.org> wrote:

>> When a custom `FileView` is used and folder traversal is restricted to a 
>> particular directory NPE occurs when user tries to traverse/select other 
>> folders except traversable folder. This is caused because when user selects 
>> folder other than traversable, the traversal is rejected and hence no file 
>> is selected as `currentDirectory` of `JFileChooser`. When user tries to 
>> access the restricted folder second time, previous selected file check is 
>> failing because of NPE since `getFileChooser().getCurrentDirectory();` is 
>> null. To fix the issue, NPE check is added.
>
> Tejesh R has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Test case update

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 67:

> 65:         //Initialize the components
> 66:         final String INSTRUCTIONS = """
> 67:                 Instructions to Test:

JFileChooser extends JComponent, probably we can create a frame with embedded 
JFileChooser and programmatically change the value of that "Look-In ComboBox"-> 
and catch an exception.

-------------

PR: https://git.openjdk.org/jdk/pull/10485

Reply via email to