On Tue, 4 Oct 2022 18:00:32 GMT, Damon Nguyen <[email protected]> wrote:

>> Update the freetype md file with the newly generated md file from 
>> attribution tool. The new format slightly differs from the previous version 
>> when separating different licenses. Added logic for combining of copyright 
>> lines and support for other licenses such as MIT.
>
> Damon Nguyen has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains two additional 
> commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8293672/updateFreeTypeMd
>  - Update md file

src/java.desktop/share/legal/freetype.md line 2:

> 1: ## The FreeType Project: Freetype v2.12.1
> 2: 

Why does this show a .0 -> .1 update ?
The currently checked in file was updated in July so it already has .1 .. so 
that is very puzzling to me.

src/java.desktop/share/legal/freetype.md line 542:

> 540: /*
> 541:  * Copyright 2000 Computing Research Labs, New Mexico State University
> 542:  * Copyright 2001-2015

Why did this notice need to be moved down to the end of the file ?
It makes the diff look bigger than it actually is and I can't imagine any 
reason we would need to change the order.

-------------

PR: https://git.openjdk.org/jdk/pull/10561

Reply via email to