On Tue, 4 Oct 2022 17:57:46 GMT, Damon Nguyen <[email protected]> wrote:

>> src/java.desktop/share/legal/freetype.md line 542:
>> 
>>> 540: /*
>>> 541:  * Copyright 2000 Computing Research Labs, New Mexico State University
>>> 542:  * Copyright 2001-2015
>> 
>> Why did this notice need to be moved down to the end of the file ?
>> It makes the diff look bigger than it actually is and I can't imagine any 
>> reason we would need to change the order.
>
> This is due to the addition of the MIT license being treated as a separate 
> license from the freetype license. In the modified tool, licenses are 
> separated by license type. The additional freetype licenses are "variants" of 
> the primary license (freetype) so it seemed to make sense for it to follow 
> the freetype & GPL license. Then, other licenses (such as MIT in this case) 
> follow afterwards.
> 
> This can be manually modified to maintain the old order but I believed it 
> made more sense this way in the tool since variants of the primary license 
> would follow the primary license.

Well if it is only a one-off...

BTW phrases such as "the modified tool" etc are very out of place here .. I 
don't see a tool in this PR, do you ?
I believe you are referring to some script(s) that not part of OpenJDK that you 
are using to produce these updates.

-------------

PR: https://git.openjdk.org/jdk/pull/10561

Reply via email to