> The previous change to AquaComboBoxUI had 1 pixel of overlap between the text 
> field and the combo button. This caused a few pixels to darken sometimes when 
> an editable combobox is displayed. Since this test passes sometimes and fails 
> some other times, it was not initially detected.
> 
> Since these few darkening pixels occur due to the change in AquaComboBoxUI, 
> no reasonable change to the test could really be made, and the change would 
> need to be to the class for the combobox. This fix was tested with a high 
> count repeat and no failures occurred for various macOS systems.
> 
> Also removing the test from the problem list.

Damon Nguyen has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now contains four commits:

 - Merge branch 'master' into 8294254/overlapFixEditableCombobox
 - Merge branch 'openjdk:master' into 8294254/overlapFixEditableCombobox
 - Remove test from problem list
 - Adjust rect width to remove overlap

-------------

Changes: https://git.openjdk.org/jdk/pull/10626/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10626&range=01
  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/10626.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10626/head:pull/10626

PR: https://git.openjdk.org/jdk/pull/10626

Reply via email to