On Mon, 10 Oct 2022 18:41:24 GMT, Damon Nguyen <[email protected]> wrote:
>> The previous change to AquaComboBoxUI had 1 pixel of overlap between the >> text field and the combo button. This caused a few pixels to darken >> sometimes when an editable combobox is displayed. Since this test passes >> sometimes and fails some other times, it was not initially detected. >> >> Since these few darkening pixels occur due to the change in AquaComboBoxUI, >> no reasonable change to the test could really be made, and the change would >> need to be to the class for the combobox. This fix was tested with a high >> count repeat and no failures occurred for various macOS systems. >> >> Also removing the test from the problem list. > > Damon Nguyen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8294254/overlapFixEditableCombobox > - Merge branch 'openjdk:master' into 8294254/overlapFixEditableCombobox > - Remove test from problem list > - Adjust rect width to remove overlap Its good that JComboBox misalignment issue is resolved under : https://bugs.openjdk.org/browse/JDK-8054572(I used to observe this at all places in SwingSet2 while testing Lanai) I ran javax/swing/plaf/aqua/CustomComboBoxFocusTest.java without this change in built-in display and external display: Built-in display(uiScale 2) : Fails 1/5 times External display(uiScale 1) : Fails 3/5 times Initially i was also under the impression that display scaling in test might be the root cause and making it run at some default scaling will solve the issue. But looks like this is a product regression introduced with fix under https://bugs.openjdk.org/browse/JDK-8054572. Since the current fix takes care of both https://bugs.openjdk.org/browse/JDK-8054572 & https://bugs.openjdk.org/browse/JDK-8073001. This product change looks good to me. ------------- Marked as reviewed by jdv (Reviewer). PR: https://git.openjdk.org/jdk/pull/10626
