On Fri, 2 Dec 2022 03:43:57 GMT, Sergey Bylokhov <[email protected]> wrote:
>> The above test was failing due to incorrect pixel color and wrong window >> bounds on Mac-ARM, Windows and Linux platforms. >> >> The following changes have been made: >> - Correct window bounds are obtained using the current ScreenDevice's >> DefaultConfig bounds (this test checks FullScreen functionality on multiple >> screen devices). >> - Color tolerance has been added for color check >> - Instead of scanning the full screen to check pixel color, vertical and >> horizontal scans are done at the far right and bottom end to ensure that >> window is in full screen mode w.r.t to screen device and the window bounds >> are as expected. >> >> CI testing passes on all platforms (tested 50 times per platform). > > test/jdk/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java line 89: > >> 87: device.setFullScreenWindow(wRed); >> 88: sleep(); >> 89: testWindowBounds(device.getFullScreenWindow().getBounds(), >> wRed); > > You changed the code > from: > comparing the bounds of the display mode and the bounds of the window > to: > comparing the bounds of the window and the bounds of the window > I do not think it is the right thing to do. @mrserb I noticed that the difference in actual size vs display mode dimensions is because the actual size is scaled down by the device's current scale unlike display mode. This can be resolved by running the test at uiScale=1. ------------- PR: https://git.openjdk.org/jdk/pull/11462
