On Tue, 6 Dec 2022 06:14:56 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> test/jdk/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java line 44:
>> 
>>> 42:  * @bug 8003173 7019055
>>> 43:  * @summary Full-screen windows should have the proper insets.
>>> 44:  * @requires (os.family != "linux")
>> 
>> You should not exclude the test on the platform which has a bug in it. On 
>> Linux, this test fails if a non-accelerated java2d pipeline is used, and we 
>> just "maximize the frame", this problem is similar to Windows described in 
>> JDK-7019055.
>> 
>> Note that you deleted the reference to this bug 
>> https://bugs.openjdk.org/browse/JDK-8266245 from problem list, take a look 
>> at the images attached to that report, both of them have black/empty 
>> rectangle on the top. This looks similar to the initial bug this test was 
>> created https://bugs.openjdk.org/browse/JDK-8003173
>> 
>> So looks like this is not a test issue on all platforms, other than the  
>> `device.getDefaultConfiguration().getBounds()` usage.
>
> @mrserb Since the current test fix works on other platforms (windows, mac) 
> other than linux, can the other platforms be removed and the test be 
> problemlisted only on linux platform until the product bug is fixed on linux 
> then? Additionally the test was failing on Mac-ARM due to color mismatch that 
> was fixed by adding tolerance.

It is still unclear why tolerance is needed in this test and is not needed in 
the CheckCommonColors?

-------------

PR: https://git.openjdk.org/jdk/pull/11462

Reply via email to