> That's a real pain how skipped tests just silently pass. Regression tests > should catch regressions, not pretend that everything is OK when they in fact > didn't test anything
There are several options to resolve this problem without failing the tests: - you can provide diagnostic message, so passing for configurations missing necessary fonts won’t be silent - create your own font with necessary properties and submit it within the fix Best Regards, Alexey > On Dec 3, 2022, at 2:11 PM, Nikita Gubarkov <[email protected]> wrote: > > On Thu, 1 Dec 2022 19:38:44 GMT, Nikita Gubarkov <[email protected]> wrote: > >>> It was implemented in JetBrains Runtime a year ago and was ported & >>> refactored for this PR >>> It includes: >>> - Bitmap glyph loading via Freetype >>> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >>> bilinear-mipmap style algorithms depending on the text antialiasing hint >>> - Storing BGRA glyphs in glyph cache & rendering them as plain images, as >>> currently used XRender text drawing functions doesn't support colored glyphs >>> - Small fixes in related code like null-checks which could cause NPE & >>> comment typos >> >> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix pointer to jlong conversion on x86 > > That's a real pain how skipped tests just silently pass. Regression tests > should catch regressions, not pretend that everything is OK when they in fact > didn't test anything. I believe skipping a test should be explicit, it's not > a "Passed" nor "Failed" state, it's more like "Unknown". Would be very > unfortunate to see green tests in CI and then find a regression which > happened million years ago just because this test was skipped all the time > but you never knew. Even agreeing on some special exit code for skipped tests > would already be a good step forward. Just a point for a discussion. > > ------------- > > PR: https://git.openjdk.org/jdk/pull/4798
